linux-kernel - Re: [PATCH v3 09/22] i2c: tegra: Clean up probe function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <77562fdc-0314-b711-90b6-2fc90940f472@gmail.com>
Date:   Thu, 3 Sep 2020 18:56:24 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        Wolfram Sang <wsa@...-dreams.de>,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        linux-tegra@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 09/22] i2c: tegra: Clean up probe function

03.09.2020 17:02, Andy Shevchenko пишет:
> On Thu, Sep 3, 2020 at 4:48 PM Dmitry Osipenko <digetx@...il.com> wrote:
>> 03.09.2020 14:17, Andy Shevchenko пишет:
>>> On Thu, Sep 3, 2020 at 3:54 AM Dmitry Osipenko <digetx@...il.com> wrote:
> 
> ...
> 
>>>> +       of_property_read_u32(np, "clock-frequency", &bus_clk_rate);
>>>> +       i2c_dev->bus_clk_rate = bus_clk_rate;
>>>
>>> Hmm... I dunno if Wolfram is going to implement a special helper
>>> exactly for this. I remember we discussed that with him during v5.8
>>> (?) times.
>>
>> I now see that there is a i2c_parse_fw_timings() which parses
>> "clock-frequency" and other common properties. I could switch to use
>> that helper, but not sure whether it would be really worthwhile because
>> only one property is needed to be parsed. I'll consider this change for
>> v4, thank you for the suggestion!
> 
> That's exactly why I was wondering about the current state of affairs
> with the discussed helper which should only parse the clock-frequency
> property.
> 

Alright, I see that many other I2C drivers are in the same position, so
perhaps should better to keep the current variant as-is until a common
solution will become available.