linux-kernel - Re: [linux-sunxi] [PATCH 05/16] ASoc: sun4i-i2s: Add 20 and 24 bit support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200904162355.GA49830@sirena.org.uk>
Date:   Fri, 4 Sep 2020 17:23:55 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Charles Keepax <ckeepax@...nsource.cirrus.com>
Cc:     Maxime Ripard <maxime@...no.tech>,
        Samuel Holland <samuel@...lland.org>,
        devicetree@...r.kernel.org,
        Jernej Škrabec <jernej.skrabec@...l.net>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        linux-sunxi@...glegroups.com, Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Marcus Cooper <codekipper@...il.com>,
        Chen-Yu Tsai <wens@...e.org>, peron.clem@...il.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [linux-sunxi] [PATCH 05/16] ASoc: sun4i-i2s: Add 20 and 24 bit
 support

On Fri, Sep 04, 2020 at 04:16:49PM +0000, Charles Keepax wrote:

> My understanding is physical_width refers to the in memory
> representation, but shouldn't be used to control the slot width
> on the bus. If not specified otherwise (say through the set_tdm
> callback), and if the appropriate BCLK is supported, then the slot
> should be just large enough to hold the data.

Indeed.  The framework isn't great here in tying the memory and wire
formats together, ideally there would be more support for them being
unrelated without DPCM.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)