linux-kernel - [PATCH] drm: xlnx: fix build warning & errors when DMADEVICES is not set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f7bdabb-e28b-2cc1-5fbd-92c381299ba9@infradead.org>
Date:   Thu, 3 Sep 2020 21:41:08 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     LKML <linux-kernel@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Hyun Kwon <hyun.kwon@...inx.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:     kernel test robot <lkp@...el.com>
Subject: [PATCH] drm: xlnx: fix build warning & errors when DMADEVICES is not
 set

From: Randy Dunlap <rdunlap@...radead.org>

Fix kconfig warnings & build errors caused by DRM_ZYNQMP_DPSUB.

Any driver that selects DMA_ENGINE should make sure that
DMADEVICES is already enabled.
As is, this causes build errors in many other drivers.

See https://lore.kernel.org/lkml/202009020239.oUPh82Xc%25lkp@intel.com/
for the numerous build errors.

WARNING: unmet direct dependencies detected for DMA_ENGINE
  Depends on [n]: DMADEVICES [=n]
  Selected by [y]:
  - DRM_ZYNQMP_DPSUB [=y] && HAS_IOMEM [=y] && (ARCH_ZYNQMP || COMPILE_TEST [=y]) && COMMON_CLK [=y] && DRM [=y] && OF [=y]

Reported-by: kernel test robot <lkp@...el.com>
Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Hyun Kwon <hyun.kwon@...inx.com>
Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: dri-devel@...ts.freedesktop.org
---
 drivers/gpu/drm/xlnx/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20200903.orig/drivers/gpu/drm/xlnx/Kconfig
+++ linux-next-20200903/drivers/gpu/drm/xlnx/Kconfig
@@ -2,6 +2,7 @@ config DRM_ZYNQMP_DPSUB
 	tristate "ZynqMP DisplayPort Controller Driver"
 	depends on ARCH_ZYNQMP || COMPILE_TEST
 	depends on COMMON_CLK && DRM && OF
+	depends on DMADEVICES
 	select DMA_ENGINE
 	select DRM_GEM_CMA_HELPER
 	select DRM_KMS_CMA_HELPER