linux-kernel - Re: [PATCH 3/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.14

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200904063514.GB1506@ninjato>
Date:   Fri, 4 Sep 2020 08:35:14 +0200
From:   Wolfram Sang <wsa+renesas@...g-engineering.com>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>, swboyd@...omium.org,
        Adrian Hunter <adrian.hunter@...el.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Hu Ziji <huziji@...vell.com>,
        Jaehoon Chung <jh80.chung@...sung.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Jun Nie <jun.nie@...aro.org>,
        Kevin Hilman <khilman@...libre.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        Peter Ujfalusi <peter.ujfalusi@...com>,
        Ray Jui <rjui@...adcom.com>,
        Robert Richter <rrichter@...vell.com>,
        Saiyam Doshi <saiyamdoshi.in@...il.com>,
        Scott Branden <sbranden@...adcom.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Stefan Wahren <wahrenst@....net>,
        bcm-kernel-feedback-list@...adcom.com,
        linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mmc@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org
Subject: Re: [PATCH 3/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that
 existed in v4.14

On Thu, Sep 03, 2020 at 04:24:38PM -0700, Douglas Anderson wrote:
> This is like commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
> probe") but applied to a whole pile of drivers.  This batch converts
> the drivers that appeared to be around in the v4.14 timeframe.

The LTS granularity of patches is a nice idea! I will keep it in mind.

> 
> Signed-off-by: Douglas Anderson <dianders@...omium.org>

In general, I like more coverage of async probing. It makes sense for
SD/MMC, I think.

Reviewed-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

>  drivers/mmc/host/renesas_sdhi_internal_dmac.c | 1 +
>  drivers/mmc/host/renesas_sdhi_sys_dmac.c      | 1 +

For these two also:

Tested-by: Wolfram Sang <wsa+renesas@...g-engineering.com> # SDHI drivers

The speedups somewhat match the expected values and no regressions when
checksumming a large file.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)