linux-kernel - Re: [PATCH] crypto: Mark tfm buffer as non leak.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200904071709.GA24539@gondor.apana.org.au>
Date:   Fri, 4 Sep 2020 17:17:09 +1000
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Peter Enderborg <peter.enderborg@...y.com>
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        davem@...emloft.net, peter.enderborg@...y.com
Subject: Re: [PATCH] crypto: Mark tfm buffer as non leak.

Peter Enderborg <peter.enderborg@...y.com> wrote:
>
> This is caused by tfm = (struct crypto_tfm *)(mem + tfmsize);
> that is keept instead of the allocated buffer in mem.
> Reference counting is done on alg.

I don't understand why this is necessary.  We end up returning
mem in crypto_create_tfm_node and that is the primary means of
getting to the object.

The tfm pointer is just an internal thing.  So why do we have
to mark mem as not a leak?

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt