linux-kernel - Re: [PATCH RESEND 04/10] crypto: hisilicon/zip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Sep 2020 17:40:04 +1000
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     "shenyang (M)" <shenyang39@...wei.com>
Cc:     David Laight <David.Laight@...LAB.COM>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "xuzaibo@...wei.com" <xuzaibo@...wei.com>,
        "wangzhou1@...ilicon.com" <wangzhou1@...ilicon.com>
Subject: Re: [PATCH RESEND 04/10] crypto: hisilicon/zip - replace 'sprintf'
 with 'scnprintf'

On Wed, Aug 26, 2020 at 04:56:40PM +0800, shenyang (M) wrote:
>
> > > @@ -514,13 +514,16 @@ static int hisi_zip_core_debug_init(struct hisi_qm *qm)
> > >  	struct debugfs_regset32 *regset;
> > >  	struct dentry *tmp_d;
> > >  	char buf[HZIP_BUF_SIZE];
> > > -	int i;
> > > +	int i, ret;
> > > 
> > >  	for (i = 0; i < HZIP_CORE_NUM; i++) {
> > >  		if (i < HZIP_COMP_CORE_NUM)
> > > -			sprintf(buf, "comp_core%d", i);
> > > +			ret = scnprintf(buf, HZIP_BUF_SIZE, "comp_core%d", i);
> > >  		else
> > > -			sprintf(buf, "decomp_core%d", i - HZIP_COMP_CORE_NUM);
> > > +			ret = scnprintf(buf, HZIP_BUF_SIZE, "decomp_core%d",
> > > +					i - HZIP_COMP_CORE_NUM);
> > > +		if (!ret)
> > > +			return -ENOMEM;
> > 
> > and that is just so wrong - did you even try to test
> > the 'buffer too small' code path?
> 
> Do you means the check is unnecessary?

No he's saying that your patch does the wrong thing when the string
is truncated.

Also ENOMEM is a strange error for that case.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt