lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20200904082804.GB1214@gondor.apana.org.au> Date: Fri, 4 Sep 2020 18:28:04 +1000 From: Herbert Xu <herbert@...dor.apana.org.au> To: Krzysztof Kozlowski <krzk@...nel.org> Cc: Gilad Ben-Yossef <gilad@...yossef.com>, "David S. Miller" <davem@...emloft.net>, linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/3] crypto: sa2ul - Hide pointer and fix -Wpointer-to-int-cast in dev_dbg() On Wed, Aug 26, 2020 at 06:29:52PM +0200, Krzysztof Kozlowski wrote: > Pointers should not be printed because they might leak important > information about address space layout. Use %p to hash the value. This > also fixes compilation warnings on 32-bit architecture: > > drivers/crypto/sa2ul.c:1486:33: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > > Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org> > --- > drivers/crypto/sa2ul.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) All applied. Thanks. -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Powered by blists - more mailing lists