linux-kernel - Re: Re: Re: [RFC PATCH 4/4] i2c: at91: Move to generic GPIO bus recovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200904092032.GA32080@ninjato>
Date:   Fri, 4 Sep 2020 11:20:32 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Codrin.Ciubotariu@...rochip.com,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        robh+dt@...nel.org, Ludovic.Desroches@...rochip.com,
        Nicolas.Ferre@...rochip.com, alexandre.belloni@...tlin.com,
        linux@...linux.org.uk, kamel.bouhara@...tlin.com
Subject: Re: Re: Re: [RFC PATCH 4/4] i2c: at91: Move to generic GPIO bus
 recovery

Hi Codrin,

> The pinmux driver needs to have strict set to false, otherwise the 
> switching is not available, not at this time at least. Perhaps there is 
> room for improvement here, because the I2C bus is not using the pins 
> while we are doing GPIO recovery.

Our driver doesn't use 'strict'. The thing is that I can't describe a
pinctrl state for GPIO. GPIO is the default state until another function
is requested. Back to GPIO currently means freeing the pin again, so it
defaults back to GPIO. We are currently discussing it. Geert (CCed)
isn't very happy of describing the same pins with 'function = "gpio"'
because the Kernel already knows the mapping, just needs to revert it.
Geert, please correct me if I am wrong.

> I am not sure I'll have time the next week to work on what you asked me 
> regarding sh_mobile and PXA, but I will look into it the week after that.
> Sorry about my delayed reply, I was on vacation.

Well, no need for sh_mobile, this is my todo item :) About PXA, well, I
am still happy that you volunteered to do it, so I hope you had a
relaxing vacation!

Happy hacking,

   Wolfram

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)