linux-kernel - Re: [PATCH v5] iommu/mediatek: check 4GB mode by reading infracfg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1599215324.29997.1.camel@mtkswgap22>
Date:   Fri, 4 Sep 2020 18:28:44 +0800
From:   Miles Chen <miles.chen@...iatek.com>
To:     Joerg Roedel <joro@...tes.org>
CC:     Matthias Brugger <matthias.bgg@...il.com>,
        Rob Herring <robh@...nel.org>,
        <iommu@...ts.linux-foundation.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <wsd_upstream@...iatek.com>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        David Hildenbrand <david@...hat.com>,
        Yong Wu <yong.wu@...iatek.com>,
        Yingjoe Chen <yingjoe.chen@...iatek.com>,
        "Christoph Hellwig" <hch@....de>
Subject: Re: [PATCH v5] iommu/mediatek: check 4GB mode by reading infracfg

On Fri, 2020-09-04 at 11:42 +0200, Joerg Roedel wrote:
> On Mon, Aug 31, 2020 at 06:56:39PM +0800, Miles Chen wrote:
> > In previous discussion [1] and [2], we found that it is risky to
> > use max_pfn or totalram_pages to tell if 4GB mode is enabled.
> > 
> > Check 4GB mode by reading infracfg register, remove the usage
> > of the un-exported symbol max_pfn.
> > 
> > This is a step towards building mtk_iommu as a kernel module.
> > 
> > [1] https://lore.kernel.org/lkml/20200603161132.2441-1-miles.chen@mediatek.com/
> > [2] https://lore.kernel.org/lkml/20200604080120.2628-1-miles.chen@mediatek.com/
> > [3] https://lore.kernel.org/lkml/20200715205120.GA778876@bogus/
> > 
> > Cc: Mike Rapoport <rppt@...ux.ibm.com>
> > Cc: David Hildenbrand <david@...hat.com>
> > Cc: Yong Wu <yong.wu@...iatek.com>
> > Cc: Yingjoe Chen <yingjoe.chen@...iatek.com>
> > Cc: Christoph Hellwig <hch@....de>
> > Cc: Rob Herring <robh@...nel.org>
> > Cc: Matthias Brugger <matthias.bgg@...il.com>
> > Signed-off-by: Miles Chen <miles.chen@...iatek.com>
> 
> You forgot to add the tags here from v4, at least Matthias' Reviewed-by
> is missing. Please add the missing tags and resend.

Thanks for reminding. I'll add the tag and resend this patch ASAP.

Miles
> 
> 
> 	Joerg