linux-kernel - Re: [PATCH v3] HID: quirks: Add USB_QUIRK_IGNORE_REMOTE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200904104447.GA2727177@kroah.com>
Date:   Fri, 4 Sep 2020 12:44:47 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     PengHao <penghao@...ontech.com>
Cc:     Hans de Goede <hdegoede@...hat.com>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, johan@...nel.org, dlaz@...omium.org,
        stern@...land.harvard.edu, kerneldev@...smulder.nl,
        jonathan@...ox.net, tomasz@...esinski.eu
Subject: Re: [PATCH v3] HID: quirks: Add USB_QUIRK_IGNORE_REMOTE_WAKEUP quirk
 for BYD zhaoxin notebook

On Fri, Sep 04, 2020 at 06:38:21PM +0800, PengHao wrote:
> Hi, Hans
> 
> Thanks for the review. And sorry for I'm not really familiar with
> mailing list, so didn't reply early.
> 
> Actually the reason why I submit this patch, is the vendor ask we do
> this, they do not want enable touchpad wakeup.

That says _what_ they want to do, but we need to know _why_ this is the
case.

What is wrong with the existing touchpad wakeup functionality that is
broken on this device?  Why does this quirk have to be added, what goes
wrong if it is not added?

Please put that information in the changelog text.

thanks,

greg k-h