linux-kernel - Re: [PATCH 6/7] dt-bindings: i2c: imx: Use unevaluatedProperties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqKUHZvqT7WH4B=1NZ32o2HJ14-0wL4TYN7sQYx-fyjCsA@mail.gmail.com>
Date:   Fri, 4 Sep 2020 08:29:47 -0600
From:   Rob Herring <robh@...nel.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Anson Huang <Anson.Huang@....com>,
        Wolfram Sang <wolfram@...-dreams.de>,
        Dong Aisheng <aisheng.dong@....com>,
        linux-clk <linux-clk@...r.kernel.org>,
        devicetree@...r.kernel.org,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linux I2C <linux-i2c@...r.kernel.org>
Subject: Re: [PATCH 6/7] dt-bindings: i2c: imx: Use unevaluatedProperties

On Thu, Sep 3, 2020 at 2:36 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On Thu, 3 Sep 2020 at 18:41, Rob Herring <robh@...nel.org> wrote:
> >
> > On Sat, Aug 29, 2020 at 01:17:59PM +0200, Krzysztof Kozlowski wrote:
> > > Additional properties actually might appear (e.g. power-domains or child
> > > nodes) so use unevaluatedProperties to fix dtbs_check warnings like:
> > >
> > >   arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: i2c@...20000:
> > >     '#address-cells', '#size-cells', 'pmic@25' do not match any of the regexes: 'pinctrl-[0-9]+'
> > >
> > > Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> > > ---
> > >  Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > NAK. See https://lore.kernel.org/r/CAL_JsqKPXJxsHPS34_TCf9bwgKxZNSV4mvQR-WKRnknQVtGGxQ@mail.gmail.com/
>
> I can reference the generic i2c-controller schema and add missing
> properties but what to do with children (pmic@25 and many other)? I
> see that all of the other I2C controller dtschema files solve it by
> skipping "additionalProperties: false". Is this the way to go with I2C
> controllers?

If there's a $ref to the i2c schema, then using unevaluatedProperties
is correct.

Rob