linux-kernel - Re: [PATCH 3/3] iommu: qcom: Drop of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200904145603.GE3715@yoga>
Date:   Fri, 4 Sep 2020 09:56:03 -0500
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Joerg Roedel <joro@...tes.org>,
        David Woodhouse <dwmw2@...radead.org>,
        Lu Baolu <baolu.lu@...ux.intel.com>,
        Rob Clark <robdclark@...il.com>,
        Andy Gross <agross@...nel.org>,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 3/3] iommu: qcom: Drop of_match_ptr to fix
 -Wunused-const-variable

On Tue 28 Jul 12:08 CDT 2020, Krzysztof Kozlowski wrote:

> The of_device_id is included unconditionally by of.h header and used
> in the driver as well.  Remove of_match_ptr to fix W=1 compile test
> warning with !CONFIG_OF:
> 
>     drivers/iommu/qcom_iommu.c:910:34: warning: 'qcom_iommu_of_match' defined but not used [-Wunused-const-variable=]
>       910 | static const struct of_device_id qcom_iommu_of_match[] = {
> 

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  drivers/iommu/qcom_iommu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c
> index af6bec3ace00..9535a6af7553 100644
> --- a/drivers/iommu/qcom_iommu.c
> +++ b/drivers/iommu/qcom_iommu.c
> @@ -752,7 +752,7 @@ static const struct of_device_id ctx_of_match[] = {
>  static struct platform_driver qcom_iommu_ctx_driver = {
>  	.driver	= {
>  		.name		= "qcom-iommu-ctx",
> -		.of_match_table	= of_match_ptr(ctx_of_match),
> +		.of_match_table	= ctx_of_match,
>  	},
>  	.probe	= qcom_iommu_ctx_probe,
>  	.remove = qcom_iommu_ctx_remove,
> @@ -915,7 +915,7 @@ static const struct of_device_id qcom_iommu_of_match[] = {
>  static struct platform_driver qcom_iommu_driver = {
>  	.driver	= {
>  		.name		= "qcom-iommu",
> -		.of_match_table	= of_match_ptr(qcom_iommu_of_match),
> +		.of_match_table	= qcom_iommu_of_match,
>  		.pm		= &qcom_iommu_pm_ops,
>  	},
>  	.probe	= qcom_iommu_device_probe,
> -- 
> 2.17.1
>