linux-kernel - Re: [PATCH] init: fix error check in clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200904160414.GA31683@lst.de>
Date:   Fri, 4 Sep 2020 18:04:14 +0200
From:   Christoph Hellwig <hch@....de>
To:     Barret Rhoden <brho@...gle.com>
Cc:     hch@....de, gregkh@...uxfoundation.org, linux-api@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-raid@...r.kernel.org, rafael@...nel.org,
        torvalds@...ux-foundation.org, viro@...iv.linux.org.uk,
        luto@...nel.org
Subject: Re: [PATCH] init: fix error check in clean_path()

On Fri, Sep 04, 2020 at 09:53:32AM -0400, Barret Rhoden wrote:
> init_stat() returns 0 on success, same as vfs_lstat().  When it replaced
> vfs_lstat(), the '!' was dropped.
> 
> Fixes: 716308a5331b ("init: add an init_stat helper")
> Signed-off-by: Barret Rhoden <brho@...gle.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@....de>