linux-kernel - Re: [PATCH v2 1/1] Input: atmel_mxt_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <610b2513-7d62-386d-ed2a-54e1bea4df43@gmail.com>
Date:   Sat, 5 Sep 2020 21:57:08 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Jiada Wang <jiada_wang@...tor.com>
Cc:     "nick@...anahar.org" <nick@...anahar.org>,
        "dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Andrew_Gabbasov@...tor.com" <Andrew_Gabbasov@...tor.com>,
        "erosca@...adit-jv.com" <erosca@...adit-jv.com>
Subject: Re: [PATCH v2 1/1] Input: atmel_mxt_ts - implement I2C retries

05.09.2020 21:02, Andy Shevchenko пишет:
...
>      #define MXT_CRC_TIMEOUT                1000    /* msec */
>      #define MXT_FW_RESET_TIME      3000    /* msec */
>      #define MXT_FW_CHG_TIMEOUT     300     /* msec */
>     +#define MXT_WAKEUP_TIME                25      /* msec */
> 
> 
> Can we simple add _MS unit suffix to the definition?

I'd expect this

>      /* Command to unlock bootloader */
>      #define MXT_UNLOCK_CMD_MSB     0xaa
>     @@ -626,6 +627,7 @@ static int __mxt_read_reg(struct i2c_client *client,
>             struct i2c_msg xfer[2];
>             u8 buf[2];
>             int ret;
>     +       bool retry = false;
> 
> 
> Keep this ordered by length.

and this to be separate patches that are cleaning whole driver code,
otherwise there are no much benefits.