linux-kernel - Re: [PATCH] PCI: keystone: Enable compile-testing on !ARM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200906194850.63glbnehjcuw356k@lenovo-laptop>
Date:   Sun, 6 Sep 2020 20:48:50 +0100
From:   Alex Dewar <alex.dewar90@...il.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Alex Dewar <alex.dewar90@...il.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Murali Karicheri <m-karicheri2@...com>,
        Thierry Reding <treding@...dia.com>,
        Andrew Murray <amurray@...goodpenguin.co.uk>,
        Vidya Sagar <vidyas@...dia.com>,
        Dilip Kota <eswara.kota@...ux.intel.com>,
        Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
        Jonathan Chocron <jonnyc@...zon.com>,
        linux-pci@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] PCI: keystone: Enable compile-testing on !ARM

On Sun, Sep 06, 2020 at 02:19:44PM +0200, Krzysztof Kozlowski wrote:
> On Fri, 4 Sep 2020 at 20:56, Alex Dewar <alex.dewar90@...il.com> wrote:
> >
> > Currently the Keystone driver can only be compile-tested on ARM, but
> > this restriction seems unnecessary. Get rid of it to increase test
> > coverage.
> >
> > Build-tested on x86 with allyesconfig.
> 
> You should at least build it on x86_64, powerpc and MIPS. These are
> widely available (e.g. in most of distros, or here:
> https://mirrors.edge.kernel.org/pub/tools/crosstool/). Useful is also
> riscv and sh (specially sh lacks certain headers/features).

Good suggestion. I've built it on x86, ppc, mips and riscv. sh wouldn't
build because of some kbuild dependency, rather than a compiler error.
I'll send a v2 with an updated commit message.

> 
> Best regards,
> Krzysztof