linux-kernel - Re: [PATCH net-next] net: ethernet: fec: remove redundant null check before clk_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200907133904.4672abf1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 7 Sep 2020 13:39:04 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andy Duan <fugang.duan@....com>
Cc:     Zhang Changzhong <zhangchangzhong@...wei.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: ethernet: fec: remove redundant null
 check before clk_disable_unprepare()

On Mon, 7 Sep 2020 13:14:50 +0000 Andy Duan wrote:
> From: Zhang Changzhong <zhangchangzhong@...wei.com> Sent: Monday, September 7, 2020 8:50 PM
> > Because clk_prepare_enable() and clk_disable_unprepare() already checked
> > NULL clock parameter, so the additional checks are unnecessary, just remove
> > them.
> > 
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>  
> 
> Acked-by: Fugang Duan <fugang.duan@....com>

Applied, thanks!