linux-kernel - Re: [PATCH net-next] net: ethernet: dnet: Remove set but unused variable 'len'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200907135842.38f0c211@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 7 Sep 2020 13:58:42 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Wang Hai <wanghai38@...wei.com>
Cc:     <davem@...emloft.net>, <f.fainelli@...il.com>, <timur@...nel.org>,
        <zhengdejin5@...il.com>, <hkallweit1@...il.com>, <leon@...nel.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: ethernet: dnet: Remove set but unused
 variable 'len'

On Mon, 7 Sep 2020 22:12:07 +0800 Wang Hai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/ethernet/dnet.c: In function dnet_start_xmit
> drivers/net/ethernet/dnet.c:511:15: warning: variable ‘len’ set but not used [-Wunused-but-set-variable]
> 
> commit 4796417417a6 ("dnet: Dave DNET ethernet controller driver (updated)")
> involved this unused variable, remove it.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wang Hai <wanghai38@...wei.com>

tx_status is also not used. But I guess one change per commit, 
so applied. Thanks!