lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 Sep 2020 14:49:49 -0700 From: Jonathan Bakker <xc-racer2@...e.ca> To: Krzysztof Kozlowski <krzk@...nel.org>, Kukjin Kim <kgene@...nel.org>, Rob Herring <robh+dt@...nel.org>, Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>, Peter Meerwald-Stadler <pmeerw@...erw.net>, Paweł Chmiel <pawel.mikolaj.chmiel@...il.com>, linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org Subject: Re: [PATCH 03/25] dt-bindings: iio: adc: exynos-adc: do not require syscon on S5Pv210 Looking at this again, it appears that there is actually control for it at offset 0x6818 of pmu_syscon (0xe0108000) [1]. However, it defaults to enabled so it's not required for proper use of the block. Whether it should be present in the schema/DTS is up to you. Thanks, Jonathan [1] https://android.googlesource.com/kernel/samsung/+/refs/heads/android-samsung-3.0-jb-mr0/arch/arm/mach-s5pv210/include/mach/regs-clock.h#325 On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote: > The ADC in S5Pv210 does not have ADC phy registers in separate block for > which syscon would be needed. Remove this requirement to fix dtbs_check > warnings like: > > arch/arm/boot/dts/s5pv210-fascinate4g.dt.yaml: adc@...00000: 'samsung,syscon-phandle' is a required property > > Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org> > --- > .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > index 89b4f9c252a6..75174af72288 100644 > --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > @@ -81,7 +81,6 @@ allOf: > - samsung,exynos-adc-v2 > - samsung,exynos3250-adc > - samsung,exynos4212-adc > - - samsung,s5pv210-adc > then: > required: > - samsung,syscon-phandle >
Powered by blists - more mailing lists