linux-kernel - Re: [linux-sunxi] Re: [PATCH v6 18/18] crypto: sun8i-ce: fix some style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200907071617.GA11894@Red>
Date:   Mon, 7 Sep 2020 09:16:17 +0200
From:   Corentin Labbe <clabbe.montjoie@...il.com>
To:     Joe Perches <joe@...ches.com>, herbert@...dor.apana.org.au
Cc:     Corentin Labbe <clabbe@...libre.com>, davem@...emloft.net,
        mripard@...nel.org, wens@...e.org,
        linux-arm-kernel@...ts.infradead.org, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-sunxi@...glegroups.com
Subject: Re: [linux-sunxi] Re: [PATCH v6 18/18] crypto: sun8i-ce: fix some
 style issue

On Fri, Sep 04, 2020 at 12:37:19PM -0700, Joe Perches wrote:
> On Fri, 2020-09-04 at 11:10 +0000, Corentin Labbe wrote:
> > This patch fix a double empty line issue reported by checkpatch.
> > While at it, since now the maximum line length is now 100, reorder some
> > wrapped line.
> []
> > diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
> []
> > @@ -164,12 +164,10 @@ static int sun8i_ce_cipher_prepare(struct crypto_engine *engine, void *async_req
> >  				goto theend_key;
> >  			}
> >  			offset = areq->cryptlen - ivsize;
> > -			scatterwalk_map_and_copy(rctx->backup_iv, areq->src,
> > -						 offset, ivsize, 0);
> > +			scatterwalk_map_and_copy(rctx->backup_iv, areq->src, offset, ivsize, 0);
> >  		}
> >  		memcpy(rctx->bounce_iv, areq->iv, ivsize);
> > -		addr_iv = dma_map_single(ce->dev, rctx->bounce_iv, rctx->ivlen,
> > -					 DMA_TO_DEVICE);
> > +		addr_iv = dma_map_single(ce->dev, rctx->bounce_iv, rctx->ivlen, DMA_TO_DEVICE);
> 
> coding-style.rst:
> 
>    Statements longer than 80 columns should be broken into sensible chunks,
>    unless exceeding 80 columns significantly increases readability and does
>    not hide information.
> 
> Do these longer lines make the code significantly more readable?
> I don't think they do.
> 

Oh I saw the increase in checkpatch.pl but didnt saw that it was still 80 in coding-style.rst.
Anyway as maintainer of this driver, I prefer unwrapped lines.

I let Herbert to choose to apply the serie without this last patch or not.