linux-kernel - Re: [PATCH v2] /dev/zero: also implement ->read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200907084536.GA1058178@kroah.com>
Date:   Mon, 7 Sep 2020 10:45:36 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Christoph Hellwig <hch@....de>
Cc:     arnd@...db.de, linux-kernel@...r.kernel.org,
        Christophe Leroy <christophe.leroy@...roup.eu>
Subject: Re: [PATCH v2] /dev/zero: also implement ->read

On Mon, Sep 07, 2020 at 10:21:39AM +0200, Christoph Hellwig wrote:
> On Mon, Sep 07, 2020 at 10:21:14AM +0200, Greg KH wrote:
> > On Mon, Sep 07, 2020 at 09:51:43AM +0200, Christoph Hellwig wrote:
> > > Christophe reported a major speedup due to avoiding the iov_iter
> > > overhead, so just add this trivial function.
> > > 
> > > Suggested-by: Christophe Leroy <christophe.leroy@...roup.eu>
> > > Signed-off-by: Christoph Hellwig <hch@....de>
> > > Tested-by: Christophe Leroy <christophe.leroy@...roup.eu>
> > > ---
> > > 
> > > Changes since v1:
> > >  - fix the Suggested-by: tag
> > >  - report the actually read bytes in case of a partial clear_user
> > >  - remove an impossible to hit conditional
> > > 
> > >  drivers/char/mem.c | 28 ++++++++++++++++++++++++++++
> > >  1 file changed, 28 insertions(+)
> > 
> > I already merged your v1 into my tree, do you want me to revert that and
> > then add this, or can you send me the diff to apply instead?  I can't
> > rebase my public trees.
> 
> Sure, I can send an incremental one.  I vaguely remembered you as one
> of the quilt holdouts.

That's only for stable tree work :)

thanks for the incremental patch, will go apply that now.

greg k-h