linux-kernel - Re: [PATCH 4/4] device property: Move fwnode_connection_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200907090414.GE1101646@kroah.com>
Date:   Mon, 7 Sep 2020 11:04:14 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH 4/4] device property: Move fwnode_connection_find_match()
 under drivers/base/property.c

On Fri, Sep 04, 2020 at 03:51:23PM +0300, Heikki Krogerus wrote:
> The function is now only a helper that searches the
> connection from device graph and then by checking if the
> supplied connection identifier matches a property that
> contains reference.
> 
> Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> ---
>  .../driver-api/device_connection.rst          |  43 --------
>  drivers/base/Makefile                         |   2 +-
>  drivers/base/devcon.c                         | 101 ------------------
>  drivers/base/property.c                       |  73 +++++++++++++
>  include/linux/device.h                        |   9 --
>  include/linux/property.h                      |  14 +++
>  6 files changed, 88 insertions(+), 154 deletions(-)
>  delete mode 100644 Documentation/driver-api/device_connection.rst

You also removed the documentation in this patch, which would have been
fine if you had mentioned it in the changelog text :(

I'll go queue up the first 3 patches of this series, can you split this
up into two?

thanks,

greg k-h