linux-kernel - Re: [PATCH v2 1/2] perf metric: Fix some memory leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM9d7cijN4YRtYdOC1_yRc4YerFGV1ob-MYw2ssVQDJUEWOheg@mail.gmail.com>
Date:   Mon, 7 Sep 2020 09:27:04 +0900
From:   Namhyung Kim <namhyung@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Stephane Eranian <eranian@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Andi Kleen <andi@...stfloor.org>,
        Kajol Jain <kjain@...ux.ibm.com>,
        John Garry <john.garry@...wei.com>,
        Ian Rogers <irogers@...gle.com>
Subject: Re: [PATCH v2 1/2] perf metric: Fix some memory leaks

Hi Jiri,

On Sun, Sep 6, 2020 at 9:41 PM Jiri Olsa <jolsa@...hat.com> wrote:
>
> On Sat, Sep 05, 2020 at 11:19:11AM +0900, Namhyung Kim wrote:
> > I found some memory leaks while reading the metric code.  Some are
> > real and others only occur in the error path.  When it failed during
> > metric or event parsing, it should release all resources properly.
> >
> > Cc: Kajol Jain <kjain@...ux.ibm.com>
> > Cc: John Garry <john.garry@...wei.com>
> > Cc: Ian Rogers <irogers@...gle.com>
> > Fixes: b18f3e365019d ("perf stat: Support JSON metrics in perf stat")
> > Signed-off-by: Namhyung Kim <namhyung@...nel.org>
>
> Acked-by: Jiri Olsa <jolsa@...hat.com>

Thanks for the review.  Actually I have another batch of leakage fixes
for the metric code found by ASAN.  Will post it soon..

Thanks
Namhyung