linux-kernel - Re: [PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ea9e575-e2ba-1f12-4894-3c0d271ea294@daenzer.net>
Date:   Mon, 7 Sep 2020 12:29:22 +0200
From:   Michel Dänzer <michel@...nzer.net>
To:     Vaibhav Gupta <vaibhavgupta40@...il.com>,
        Daniel Vetter <daniel@...ll.ch>
Cc:     Bjorn Helgaas <helgaas@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Bjorn Helgaas <bjorn@...gaas.com>,
        Vaibhav Gupta <vaibhav.varodek@...il.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Thierry Reding <treding@...dia.com>,
        linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org,
        Shuah Khan <skhan@...uxfoundation.org>,
        linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade
 and fix-ups.

On 2020-09-07 9:55 a.m., Daniel Vetter wrote:
> On Thu, Aug 06, 2020 at 12:52:54PM +0530, Vaibhav Gupta wrote:
>> Linux Kernel Mentee: Remove Legacy Power Management.
>>
>> The original goal of the patch series is to upgrade the power management
>> framework of radeonfb fbdev driver. This has been done by upgrading .suspend()
>> and .resume() callbacks.
>>
>> The upgrade makes sure that the involvement of PCI Core does not change the
>> order of operations executed in a driver. Thus, does not change its behavior.
>>
>> During this process, it was found that "#if defined(CONFIG_PM)" at line 1434 is
>> redundant. This was introduced in the commit
>> 42ddb453a0cd ("radeon: Conditionally compile PM code").
> 
> I do wonder whether it wouldn't be better to just outright delete these,
> we have the drm radeon driver for pretty much all the same hardware ...

In contrast to radeonfb, the radeon driver doesn't support 
suspend-to-RAM on Apple PowerPC notebooks.


-- 
Earthling Michel Dänzer               |               https://redhat.com
Libre software enthusiast             |             Mesa and X developer