linux-kernel - Re: [PATCH v3 01/19] dlb2: add skeleton for DLB 2.0 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200907130004.GD2371705@kroah.com>
Date:   Mon, 7 Sep 2020 15:00:04 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Gage Eads <gage.eads@...el.com>
Cc:     linux-kernel@...r.kernel.org, arnd@...db.de,
        magnus.karlsson@...el.com, bjorn.topel@...el.com
Subject: Re: [PATCH v3 01/19] dlb2: add skeleton for DLB 2.0 driver

On Tue, Sep 01, 2020 at 02:15:30PM -0500, Gage Eads wrote:
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2813,6 +2813,8 @@
>  #define PCI_DEVICE_ID_INTEL_ESB2_14	0x2698
>  #define PCI_DEVICE_ID_INTEL_ESB2_17	0x269b
>  #define PCI_DEVICE_ID_INTEL_ESB2_18	0x269e
> +#define PCI_DEVICE_ID_INTEL_DLB2_PF	0x2710
> +#define PCI_DEVICE_ID_INTEL_DLB2_VF	0x2711
>  #define PCI_DEVICE_ID_INTEL_ICH7_0	0x27b8
>  #define PCI_DEVICE_ID_INTEL_ICH7_1	0x27b9
>  #define PCI_DEVICE_ID_INTEL_ICH7_30	0x27b0

Doesn't the top of this file say to not add new ids?

Why are you adding these?  Can't they just stick in the driver you use
them in?  And they aren't referenced in this patch either, so even if
you did need them, they shouldn't be here :(

greg k-h