linux-kernel - Re: [PATCH v2][next] PCI: rcar-gen2: Use fallthrough pseudo-keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 7 Sep 2020 15:18:21 +0100
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Marek Vasut <marek.vasut+renesas@...il.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Subject: Re: [PATCH v2][next] PCI: rcar-gen2: Use fallthrough pseudo-keyword

On Tue, Jul 21, 2020 at 10:28:51PM -0500, Gustavo A. R. Silva wrote:
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1].
> 
> [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> ---
> Changes in v2:
>  - Update URL. Use proper URL to Linux v5.7 documentation.
>  - Add Geert's Reviewed-by tag.
>  - Update changelog text.
> 
>  drivers/pci/controller/pci-rcar-gen2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to pci/rcar, thanks.

Lorenzo

> diff --git a/drivers/pci/controller/pci-rcar-gen2.c b/drivers/pci/controller/pci-rcar-gen2.c
> index 326171cb1a97..2ec7093a7588 100644
> --- a/drivers/pci/controller/pci-rcar-gen2.c
> +++ b/drivers/pci/controller/pci-rcar-gen2.c
> @@ -228,7 +228,7 @@ static int rcar_pci_setup(int nr, struct pci_sys_data *sys)
>  		pr_warn("unknown window size %ld - defaulting to 256M\n",
>  			priv->window_size);
>  		priv->window_size = SZ_256M;
> -		/* fall-through */
> +		fallthrough;
>  	case SZ_256M:
>  		val |= RCAR_USBCTR_PCIAHB_WIN1_256M;
>  		break;
> -- 
> 2.27.0
>