linux-kernel - Re: [PATCH v2 08/11] kprobes: switch to kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200907101226.ab0d00639be953e81d4576c2@kernel.org>
Date:   Mon, 7 Sep 2020 10:12:26 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Christian Brauner <christian.brauner@...ntu.com>
Cc:     linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jonathan Corbet <corbet@....net>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Tony Luck <tony.luck@...el.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Ley Foon Tan <ley.foon.tan@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, Arnd Bergmann <arnd@...db.de>,
        Steven Rostedt <rostedt@...dmis.org>,
        Stafford Horne <shorne@...il.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Kars de Jong <jongk@...ux-m68k.org>,
        Kees Cook <keescook@...omium.org>,
        Greentime Hu <green.hu@...il.com>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Alexandre Chartre <alexandre.chartre@...cle.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Tom Zanussi <zanussi@...nel.org>,
        Xiao Yang <yangx.jy@...fujitsu.com>, linux-doc@...r.kernel.org,
        uclinux-h8-devel@...ts.sourceforge.jp, linux-ia64@...r.kernel.org,
        linux-m68k@...ts.linux-m68k.org, sparclinux@...r.kernel.org,
        kgdb-bugreport@...ts.sourceforge.net,
        linux-kselftest@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Christoph Hewllig <hch@...radead.org>,
        Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH v2 08/11] kprobes: switch to kernel_clone()

Hi,

On Wed, 19 Aug 2020 12:46:52 +0200
Christian Brauner <christian.brauner@...ntu.com> wrote:

> The old _do_fork() helper is removed in favor of the new kernel_clone() helper.
> The latter adheres to naming conventions for kernel internal syscall helpers.

This looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Thank you!

> 
> Cc: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> Cc: Alexandre Chartre <alexandre.chartre@...cle.com>
> Cc: Jonathan Corbet <corbet@....net>
> Cc: Masami Hiramatsu <mhiramat@...nel.org>
> Signed-off-by: Christian Brauner <christian.brauner@...ntu.com>
> ---
> /* v2 */
> unchanged
> ---
>  samples/kprobes/kprobe_example.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
> index 240f2435ce6f..a02f53836ee1 100644
> --- a/samples/kprobes/kprobe_example.c
> +++ b/samples/kprobes/kprobe_example.c
> @@ -2,13 +2,13 @@
>  /*
>   * NOTE: This example is works on x86 and powerpc.
>   * Here's a sample kernel module showing the use of kprobes to dump a
> - * stack trace and selected registers when _do_fork() is called.
> + * stack trace and selected registers when kernel_clone() is called.
>   *
>   * For more information on theory of operation of kprobes, see
>   * Documentation/staging/kprobes.rst
>   *
>   * You will see the trace data in /var/log/messages and on the console
> - * whenever _do_fork() is invoked to create a new process.
> + * whenever kernel_clone() is invoked to create a new process.
>   */
>  
>  #include <linux/kernel.h>
> @@ -16,7 +16,7 @@
>  #include <linux/kprobes.h>
>  
>  #define MAX_SYMBOL_LEN	64
> -static char symbol[MAX_SYMBOL_LEN] = "_do_fork";
> +static char symbol[MAX_SYMBOL_LEN] = "kernel_clone";
>  module_param_string(symbol, symbol, sizeof(symbol), 0644);
>  
>  /* For each probe you need to allocate a kprobe structure */
> -- 
> 2.28.0
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>