lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200907151555.GA10272@e121166-lin.cambridge.arm.com>
Date:   Mon, 7 Sep 2020 16:15:55 +0100
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Flavio Suligoi <f.suligoi@...m.it>
Cc:     Tom Joseph <tjoseph@...ence.com>, Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] PCI: cadence-ep: Remove obsolete path from comment

On Tue, Jun 23, 2020 at 09:48:51AM +0200, Flavio Suligoi wrote:
> This comment still refers to the old driver pathname,
> when all PCI drivers were located directly under the
> drivers/pci directory.
> 
> Anyway the function name itself is enough, so we can
> remove the overabundant path reference.
> 
> Signed-off-by: Flavio Suligoi <f.suligoi@...m.it>
> ---
> 
> v1: - after the suggestion of Bjorn, remove the whole comment line related to
>       the wrong path
>     - add: Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>
> V2: - change the subject line according to the previous commits of the
>       same file
>     - remove wrong "Acked-by ..."
> 
>  drivers/pci/controller/cadence/pcie-cadence-ep.c | 1 -
>  1 file changed, 1 deletion(-)

Applied to pci/cadence, thanks.

Lorenzo

> diff --git a/drivers/pci/controller/cadence/pcie-cadence-ep.c b/drivers/pci/controller/cadence/pcie-cadence-ep.c
> index 1c15c8352125..690eefd328ea 100644
> --- a/drivers/pci/controller/cadence/pcie-cadence-ep.c
> +++ b/drivers/pci/controller/cadence/pcie-cadence-ep.c
> @@ -276,7 +276,6 @@ static int cdns_pcie_ep_send_legacy_irq(struct cdns_pcie_ep *ep, u8 fn, u8 intx)
>  	cdns_pcie_ep_assert_intx(ep, fn, intx, true);
>  	/*
>  	 * The mdelay() value was taken from dra7xx_pcie_raise_legacy_irq()
> -	 * from drivers/pci/dwc/pci-dra7xx.c
>  	 */
>  	mdelay(1);
>  	cdns_pcie_ep_assert_intx(ep, fn, intx, false);
> -- 
> 2.17.1
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ