linux-kernel - Re: [PATCH 1/3] pinctrl: mvebu: Fix i2c sda definition for 98DX3236

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200907154508.GX3112546@lunn.ch>
Date:   Mon, 7 Sep 2020 17:45:08 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc:     jason@...edaemon.net, gregory.clement@...tlin.com,
        sebastian.hesselbarth@...il.com, robh+dt@...nel.org,
        linus.walleij@...aro.org, linux-arm-kernel@...ts.infradead.org,
        devicetree@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Kalyan Kinthada <kalyan.kinthada@...iedtelesis.co.nz>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH 1/3] pinctrl: mvebu: Fix i2c sda definition for 98DX3236

On Mon, Sep 07, 2020 at 02:41:47PM +1200, Chris Packham wrote:
> Per the datasheet the i2c functions use MPP_Sel=0x1. They are documented
> as using MPP_Sel=0x4 as well but mixing 0x1 and 0x4 is clearly wrong. On
> the board tested 0x4 resulted in a non-functioning i2c bus so stick with
> 0x1 which works.
> 
> Fixes: d7ae8f8dee7f ("pinctrl: mvebu: pinctrl driver for 98DX3236 SoC")
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew