[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <61845513-bf41-1c15-126d-8470a23b178e@gmail.com>
Date: Mon, 7 Sep 2020 17:36:30 +0300
From: Dmitry Osipenko <digetx@...il.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Laxman Dewangan <ldewangan@...dia.com>,
Wolfram Sang <wsa@...-dreams.de>,
Michał Mirosław <mirq-linux@...e.qmqm.pl>,
linux-i2c <linux-i2c@...r.kernel.org>,
linux-tegra@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 27/36] i2c: tegra: Reorder location of functions in the
code
07.09.2020 11:27, Andy Shevchenko пишет:
> On Sun, Sep 6, 2020 at 9:52 PM Dmitry Osipenko <digetx@...il.com> wrote:
>>
>> Reorder location of functions in the code in order to have definition
>> of functions closer to the place of the invocation. This change makes
>> easier to navigate around the code and removes the need to have a
>> prototype for tegra_i2c_init().
>>
>
> This patch as 25th and one I commented before have a ping-pong style
> of programming (you touch a lot of LOCs which you introduced in
> previous patches). Please try to reorder series in a way that you
> minimize the churn of shuffling the code.
Okay, I'll improve the ordering in v6. Thanks!
Powered by blists - more mailing lists