linux-kernel - Re: [PATCH v2] gpio: siox: explicitly support only threaded irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200907161531.x7wdxmb5e3qdbtn7@pengutronix.de>
Date:   Mon, 7 Sep 2020 18:15:31 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Ahmad Fatoum <a.fatoum@...gutronix.de>
Cc:     Thorsten Scherer <t.scherer@...elmann.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        linux-gpio@...r.kernel.org, tglx@...utronix.de,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] gpio: siox: explicitly support only threaded irqs

Hello Ahmad,

On Mon, Sep 07, 2020 at 05:31:35PM +0200, Ahmad Fatoum wrote:
> The gpio-siox driver uses handle_nested_irq() to implement its
> interrupt support. This is only capable of handling threaded irq
> actions. For a hardirq action it triggers a NULL pointer oops.
> (It calls action->thread_fn which is NULL then.)
> 
> Prevent registration of a hardirq action by setting
> gpio_irq_chip::threaded to true.

cool commit log :-)

> Cc: u.kleine-koenig@...gutronix.de
> Signed-off-by: Ahmad Fatoum <a.fatoum@...gutronix.de>

Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Thanks for picking this up.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)