linux-kernel - Re: [PATCH 1/2] seccomp: don't leak memory when filter install races

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <159959037666.1186953.15847741084926154331.b4-ty@chromium.org>
Date:   Tue,  8 Sep 2020 11:40:57 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Tycho Andersen <tycho@...ho.pizza>
Cc:     Kees Cook <keescook@...omium.org>,
        syzbot+3ad9614a12f80994c32e@...kaller.appspotmail.com,
        "Tobin C . Harding" <me@...in.cc>,
        Christian Brauner <christian@...uner.io>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] seccomp: don't leak memory when filter install races

On Tue, 1 Sep 2020 19:40:16 -0600, Tycho Andersen wrote:
> In seccomp_set_mode_filter() with TSYNC | NEW_LISTENER, we first initialize
> the listener fd, then check to see if we can actually use it later in
> seccomp_may_assign_mode(), which can fail if anyone else in our thread
> group has installed a filter and caused some divergence. If we can't, we
> partially clean up the newly allocated file: we put the fd, put the file,
> but don't actually clean up the *memory* that was allocated at
> filter->notif. Let's clean that up too.
> 
> [...]

Applied, thanks!

[1/2] seccomp: don't leak memory when filter install races
      https://git.kernel.org/kees/c/a566a9012acd
[2/2] mailmap, MAINTAINERS: move to tycho.pizza
      https://git.kernel.org/kees/c/19d1d49f2a8c

Best regards,
-- 
Kees Cook