linux-kernel - Re: [PATCH v2 07/10] phy: qcom-qmp: Add support for DP in USB3+DP combo phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <159959052954.454335.18265741930513449396@swboyd.mtv.corp.google.com>
Date:   Tue, 08 Sep 2020 11:42:09 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Jonathan Marek <jonathan@...ek.ca>,
        Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        Jeykumar Sankaran <jsanka@...eaurora.org>,
        Chandan Uddaraju <chandanu@...eaurora.org>,
        Vara Reddy <varar@...eaurora.org>,
        Tanmay Shah <tanmay@...eaurora.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Manu Gautam <mgautam@...eaurora.org>,
        Sandeep Maheswaram <sanm@...eaurora.org>,
        Douglas Anderson <dianders@...omium.org>,
        Sean Paul <seanpaul@...omium.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Rob Clark <robdclark@...omium.org>
Subject: Re: [PATCH v2 07/10] phy: qcom-qmp: Add support for DP in USB3+DP combo phy

Quoting Jonathan Marek (2020-09-03 16:26:39)
> On 9/2/20 7:02 PM, Stephen Boyd wrote:
> 
> > +static int qcom_qmp_phy_configure_dp_phy(struct qmp_phy *qphy)
> > +{
[...]
> > +     writel(0x05, qphy->pcs + QSERDES_V3_DP_PHY_CFG);
> > +     writel(0x01, qphy->pcs + QSERDES_V3_DP_PHY_CFG);
> > +     writel(0x09, qphy->pcs + QSERDES_V3_DP_PHY_CFG);
> > +
> > +     writel(0x20, qphy->serdes + QSERDES_COM_RESETSM_CNTRL);
> 
> Should be QSERDES_V3_COM_RESETSM_CNTRL and not 
> QSERDES_COM_RESETSM_CNTRL, which is for older PHY versions.
> 

Thanks! Fixed it.