linux-kernel - Re: [PATCH] seccomp: don't leave dangling ->notif if file allocation fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <159959050861.1264035.3217861807726166263.b4-ty@chromium.org>
Date:   Tue,  8 Sep 2020 11:41:54 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Tycho Andersen <tycho@...ho.pizza>
Cc:     Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org,
        Christian Brauner <christian.brauner@...ntu.com>,
        Christian Brauner <christian@...uner.io>
Subject: Re: [PATCH] seccomp: don't leave dangling ->notif if file allocation fails

On Wed, 2 Sep 2020 08:09:53 -0600, Tycho Andersen wrote:
> Christian and Kees both pointed out that this is a bit sloppy to open-code
> both places, and Christian points out that we leave a dangling pointer to
> ->notif if file allocation fails. Since we check ->notif for null in order
> to determine if it's ok to install a filter, this means people won't be
> able to install a filter if the file allocation fails for some reason, even
> if they subsequently should be able to.
> 
> [...]

Applied, thanks!

[1/1] seccomp: don't leave dangling ->notif if file allocation fails
      https://git.kernel.org/kees/c/e839317900e9

as featured on my Twitch stream! ;)

-- 
Kees Cook