linux-kernel - Re: [PATCH] cpufreq: armada-37xx: Add missing MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200908050016.chsqxsnzyl4mnpfa@vireshk-i7>
Date:   Tue, 8 Sep 2020 10:30:16 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Pali Rohár <pali@...nel.org>
Cc:     Jason Cooper <jason@...edaemon.net>, Andrew Lunn <andrew@...n.ch>,
        Gregory Clement <gregory.clement@...tlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        linux-arm-kernel@...ts.infradead.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: armada-37xx: Add missing MODULE_DEVICE_TABLE

On 07-09-20, 15:27, Pali Rohár wrote:
> CONFIG_ARM_ARMADA_37XX_CPUFREQ is tristate option and therefore this
> cpufreq driver can be compiled as a module. This patch adds missing
> MODULE_DEVICE_TABLE which generates correct modalias for automatic
> loading of this cpufreq driver when is compiled as an external module.
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Pali Rohár <pali@...nel.org>
> Fixes: 92ce45fb875d7 ("cpufreq: Add DVFS support for Armada 37xx")
> ---
>  drivers/cpufreq/armada-37xx-cpufreq.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/cpufreq/armada-37xx-cpufreq.c b/drivers/cpufreq/armada-37xx-cpufreq.c
> index df1c941260d1..46f33c3a7316 100644
> --- a/drivers/cpufreq/armada-37xx-cpufreq.c
> +++ b/drivers/cpufreq/armada-37xx-cpufreq.c
> @@ -484,6 +484,12 @@ static int __init armada37xx_cpufreq_driver_init(void)
>  /* late_initcall, to guarantee the driver is loaded after A37xx clock driver */
>  late_initcall(armada37xx_cpufreq_driver_init);
>  
> +static const struct of_device_id armada37xx_cpufreq_of_match[] = {
> +	{ .compatible = "marvell,armada-3700-nb-pm" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, armada37xx_cpufreq_of_match);
> +
>  MODULE_AUTHOR("Gregory CLEMENT <gregory.clement@...e-electrons.com>");
>  MODULE_DESCRIPTION("Armada 37xx cpufreq driver");
>  MODULE_LICENSE("GPL");

Applied. Thanks.

-- 
viresh