linux-kernel - Re: [PATCH v3 00/12] video: fbdev: use generic power management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7660f403-ff17-04c2-91d3-1d1ff0510e87@samsung.com>
Date:   Tue, 8 Sep 2020 13:37:14 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Vaibhav Gupta <vaibhavgupta40@...il.com>
Cc:     Bjorn Helgaas <helgaas@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Bjorn Helgaas <bjorn@...gaas.com>,
        Vaibhav Gupta <vaibhav.varodek@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        Paul Mackerras <paulus@...ba.org>,
        Russell King <linux@...linux.org.uk>,
        Andres Salomon <dilinger@...ued.net>,
        Antonino Daplas <adaplas@...il.com>,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-geode@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v3 00/12] video: fbdev: use generic power management


On 8/19/20 8:56 PM, Vaibhav Gupta wrote:
> Linux Kernel Mentee: Remove Legacy Power Management.
> 
> The purpose of this patch series is to upgrade power management in video fbdev
> drivers. This has been done by upgrading .suspend() and .resume() callbacks.
> 
> The upgrade makes sure that the involvement of PCI Core does not change the
> order of operations executed in a driver. Thus, does not change its behavior.
> 
> In general, drivers with legacy PM, .suspend() and .resume() make use of PCI
> helper functions like pci_enable/disable_device_mem(), pci_set_power_state(),
> pci_save/restore_state(), pci_enable/disable_device(), etc. to complete
> their job.
> 
> The conversion requires the removal of those function calls, change the
> callbacks' definition accordingly and make use of dev_pm_ops structure.
> 
> All patches are compile-tested only.
> 
> Test tools:
>     - Compiler: gcc (GCC) 10.1.0
>     - allmodconfig build: make -j$(nproc) W=1 all
> 
> Vaibhav Gupta (12):
>   fbdev: gxfb: use generic power management
>   fbdev: lxfb: use generic power management
>   fbdev: via-core: use generic power management
>   fbdev: aty: use generic power management
>   fbdev: aty128fb: use generic power management
>   fbdev: nvidia: use generic power management
>   fbdev: savagefb: use generic power management
>   fbdev: cyber2000fb: use generic power management
>   fbdev: i740fb: use generic power management
>   fbdev: vt8623fb: use generic power management
>   fbdev: s3fb: use generic power management
>   fbdev: arkfb: use generic power management
> 
>  drivers/video/fbdev/arkfb.c                  | 41 ++++++-------
>  drivers/video/fbdev/aty/aty128fb.c           | 51 ++++++++++------
>  drivers/video/fbdev/aty/atyfb_base.c         | 50 ++++++++++-----
>  drivers/video/fbdev/cyber2000fb.c            | 13 ++--
>  drivers/video/fbdev/geode/gxfb.h             |  5 --
>  drivers/video/fbdev/geode/gxfb_core.c        | 36 ++++++-----
>  drivers/video/fbdev/geode/lxfb.h             |  5 --
>  drivers/video/fbdev/geode/lxfb_core.c        | 37 +++++------
>  drivers/video/fbdev/geode/lxfb_ops.c         |  4 --
>  drivers/video/fbdev/geode/suspend_gx.c       |  4 --
>  drivers/video/fbdev/i740fb.c                 | 40 +++++-------
>  drivers/video/fbdev/nvidia/nvidia.c          | 64 +++++++++++---------
>  drivers/video/fbdev/s3fb.c                   | 39 +++++-------
>  drivers/video/fbdev/savage/savagefb_driver.c | 52 ++++++++++------
>  drivers/video/fbdev/via/via-core.c           | 39 +++++-------
>  drivers/video/fbdev/vt8623fb.c               | 41 ++++++-------
>  include/linux/via-core.h                     |  2 -
>  17 files changed, 267 insertions(+), 256 deletions(-)

Applied to drm-misc-next tree, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics