linux-kernel - RE: [PATCH V2 2/3] pinctrl: imx: Support building SCU pinctrl core driver as module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 8 Sep 2020 05:06:55 +0000
From:   Anson Huang <anson.huang@....com>
To:     Aisheng Dong <aisheng.dong@....com>,
        "festevam@...il.com" <festevam@...il.com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "stefan@...er.ch" <stefan@...er.ch>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
CC:     dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH V2 2/3] pinctrl: imx: Support building SCU pinctrl core
 driver as module



> Subject: RE: [PATCH V2 2/3] pinctrl: imx: Support building SCU pinctrl core
> driver as module
> 
> > From: Anson Huang <Anson.Huang@....com>
> > Sent: Monday, September 7, 2020 8:33 PM
> >
> > Change PINCTR_IMX_SCU to tristate, remove unnecessary #ifdef and add
> > module author, description and license to support building SCU pinctrl
> > core driver as module.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@....com>
> > ---
> > Changes since V1:
> > 	- split V1 [1/2] patch to 2 patches, this patch supports building SCU
> > pinctrl core
> > 	  driver as module;
> > 	- remove unnecessary #ifdef check and #else block.
> > ---
> >  drivers/pinctrl/freescale/Kconfig       |  2 +-
> >  drivers/pinctrl/freescale/pinctrl-imx.h | 20 --------------------
> > drivers/pinctrl/freescale/pinctrl-scu.c |  5 +++++
> >  3 files changed, 6 insertions(+), 21 deletions(-)
> >
> > diff --git a/drivers/pinctrl/freescale/Kconfig
> > b/drivers/pinctrl/freescale/Kconfig
> > index 08fcf5c..452c499 100644
> > --- a/drivers/pinctrl/freescale/Kconfig
> > +++ b/drivers/pinctrl/freescale/Kconfig
> > @@ -7,7 +7,7 @@ config PINCTRL_IMX
> >  	select REGMAP
> >
> >  config PINCTRL_IMX_SCU
> > -	bool
> > +	tristate "IMX SCU pinctrl core driver"
> >  	depends on IMX_SCU
> >  	select PINCTRL_IMX
> >
> 
> [...]
> 
> > diff --git a/drivers/pinctrl/freescale/pinctrl-imx.h
> > b/drivers/pinctrl/freescale/pinctrl-imx.h
> > index 40927ca..fd8c4b6 100644
> > --- a/drivers/pinctrl/freescale/pinctrl-imx.h
> > +++ b/drivers/pinctrl/freescale/pinctrl-imx.h
> > @@ -144,7 +144,6 @@ struct imx_pinctrl_soc_info {  int
> > imx_pinctrl_probe(struct platform_device *pdev,
> >  			const struct imx_pinctrl_soc_info *info);
> >
> > -#ifdef CONFIG_PINCTRL_IMX_SCU
> >  #define BM_PAD_CTL_GP_ENABLE		BIT(30)
> >  #define BM_PAD_CTL_IFMUX_ENABLE		BIT(31)
> >  #define BP_PAD_CTL_IFMUX		27
> > @@ -157,23 +156,4 @@ int imx_pinconf_set_scu(struct pinctrl_dev
> > *pctldev, unsigned pin_id,  void imx_pinctrl_parse_pin_scu(struct
> imx_pinctrl *ipctl,
> >  			       unsigned int *pin_id, struct imx_pin *pin,
> >  			       const __be32 **list_p);
> > -#else
> > -static inline int imx_pinconf_get_scu(struct pinctrl_dev *pctldev,
> > -				      unsigned pin_id, unsigned long *config)
> > -{
> > -	return -EINVAL;
> > -}
> > -static inline int imx_pinconf_set_scu(struct pinctrl_dev *pctldev,
> > -				      unsigned pin_id, unsigned long *configs,
> > -				      unsigned num_configs)
> > -{
> > -	return -EINVAL;
> > -}
> > -static inline void imx_pinctrl_parse_pin_scu(struct imx_pinctrl *ipctl,
> > -					    unsigned int *pin_id,
> > -					    struct imx_pin *pin,
> > -					    const __be32 **list_p)
> > -{
> > -}
> > -#endif
> >  #endif /* __DRIVERS_PINCTRL_IMX_H */
> 
> Should this part of changes go to Patch 1?

OK, will send V3.

Anson