linux-kernel - Re: [PATCH] seccomp: kill process instead of thread for unknown actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <159959421548.1668991.14680355869966635620.b4-ty@chromium.org>
Date:   Tue,  8 Sep 2020 12:43:43 -0700
From:   Kees Cook <keescook@...omium.org>
To:     linux-kernel@...r.kernel.org, Rich Felker <dalias@...c.org>
Cc:     Kees Cook <keescook@...omium.org>,
        Andy Lutomirski <luto@...capital.net>,
        Will Drewry <wad@...omium.org>
Subject: Re: [PATCH] seccomp: kill process instead of thread for unknown actions

On Fri, 28 Aug 2020 21:56:13 -0400, Rich Felker wrote:
> Asynchronous termination of a thread outside of the userspace thread
> library's knowledge is an unsafe operation that leaves the process in
> an inconsistent, corrupt, and possibly unrecoverable state. In order
> to make new actions that may be added in the future safe on kernels
> not aware of them, change the default action from
> SECCOMP_RET_KILL_THREAD to SECCOMP_RET_KILL_PROCESS.

Applied, thanks!

[1/1] seccomp: kill process instead of thread for unknown actions
      https://git.kernel.org/kees/c/4d671d922d51

I tweaked the coredump logic and added a selftest (and CCed you) for
the behavior (since it wasn't included in the existing tests).

-- 
Kees Cook