linux-kernel - Re: [PATCH] clk: Make kerneldoc consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <159960167744.454335.12801752971428122073@swboyd.mtv.corp.google.com>
Date:   Tue, 08 Sep 2020 14:47:57 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Michael Turquette <mturquette@...libre.com>,
        Thierry Reding <thierry.reding@...il.com>
Cc:     linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: Make kerneldoc consistent

Quoting Thierry Reding (2020-08-27 08:28:27)
> From: Thierry Reding <treding@...dia.com>
> 
> The kerneldoc comment for of_parse_clkspec() mentions in one place that
> the value of the index parameter dictates how name is used, whereas in
> reality it's the name parameter that dictates whether or not the index
> parameter is used.

It's both name being non-null and index being >= 0. With this change we
lose that information.

> 
> In a later paragraph the kerneldoc comment does mention that the index
> will be ignored if the name is non-NULL, so make the parameter
> description consistent.

Agreed. We indicate that if name is non-NULL then this parameter is
ignored.

> 
> Signed-off-by: Thierry Reding <treding@...dia.com>
> ---
>  drivers/clk/clk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 0a9261a099bd..cf6774abebb0 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -4600,7 +4600,7 @@ EXPORT_SYMBOL(devm_of_clk_del_provider);
>  /**
>   * of_parse_clkspec() - Parse a DT clock specifier for a given device node
>   * @np: device node to parse clock specifier from
> - * @index: index of phandle to parse clock out of. If index < 0, @name is used
> + * @index: index of phandle to parse clock out of; ignored if @name is non-NULL

Maybe, ignored if @name is non-NULL. @name should be used if @index is < 0.

>   * @name: clock name to find and parse. If name is NULL, the index is used

This could say "If name is NULL, @index should be used"

>   * @out_args: Result of parsing the clock specifier
>   *
> -- 
> 2.28.0
>