linux-kernel - Re: [PATCH 4/7] drivers: leds: Add the iEi WT61P803 PUZZLE LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200908222217.GA1005@bug>
Date:   Wed, 9 Sep 2020 00:22:17 +0200
From:   Pavel Machek <pavel@....cz>
To:     Luka Kovacic <luka.kovacic@...tura.hr>
Cc:     linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-leds@...r.kernel.org,
        lee.jones@...aro.org, dmurphy@...com, robh+dt@...nel.org,
        jdelvare@...e.com, linux@...ck-us.net, andrew@...n.ch,
        jason@...edaemon.net, gregory.clement@...tlin.com,
        luka.perkov@...tura.hr
Subject: Re: [PATCH 4/7] drivers: leds: Add the iEi WT61P803 PUZZLE LED driver

Hi!

> Add support for the iEi WT61P803 PUZZLE LED driver.
> Currently only the front panel power LED is supported.
> 
> This driver depends on the iEi WT61P803 PUZZLE MFD driver.
> 
> Signed-off-by: Luka Kovacic <luka.kovacic@...tura.hr>
> Cc: Luka Perkov <luka.perkov@...tura.hr>

> +#define CMD_CHAR(x) (char)(x)

Come on... no need to hide this in macro.

> *resp_buf = kmalloc(IEI_WT61P803_PUZZLE_BUF_SIZE, GFP_KERNEL); + + 

AFAICT you'll happily dereference NULL when kmalloc fails.

If it is small, should you just put buffer on stack?
									Pavel