linux-kernel - Re: [PATCH v2 3/4] qla2xxx: Drop unused function argument from qla2x00_get_sp_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200908075237.tlx55lq344ui4z4q@beryllium.lan>
Date:   Tue, 8 Sep 2020 09:52:37 +0200
From:   Daniel Wagner <dwagner@...e.de>
To:     Arun Easi <aeasi@...vell.com>
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Nilesh Javali <njavali@...vell.com>,
        Martin Wilck <mwilck@...e.com>
Subject: Re: [PATCH v2 3/4] qla2xxx: Drop unused function argument from
 qla2x00_get_sp_from_handle()

Hi Arun,

On Mon, Sep 07, 2020 at 11:46:27PM -0700, Arun Easi wrote:
 
> How about printing the "func", which gives an indication of the caller 
> function, in the ql_log-s, rather than removing it? At least in the cases 
> like you describe, it'd give an indication which handler the path was 
> taken.

I've added the func back. Though I think it would be better to make more
use of the generic ftrace infrastructure instead reimplementing a
tracing infrastructure.

Thanks,
Daniel