linux-kernel - RE: [PATCH V3 3/3] pinctrl: imx: Support building i.MX pinctrl core driver as module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 8 Sep 2020 07:53:55 +0000
From:   Anson Huang <anson.huang@....com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     Aisheng Dong <aisheng.dong@....com>,
        Fabio Estevam <festevam@...il.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Stefan Agner <stefan@...er.ch>,
        Sascha Hauer <kernel@...gutronix.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH V3 3/3] pinctrl: imx: Support building i.MX pinctrl core
 driver as module

Hi, Arnd

> Subject: Re: [PATCH V3 3/3] pinctrl: imx: Support building i.MX pinctrl core
> driver as module
> 
> On Tue, Sep 8, 2020 at 9:34 AM Anson Huang <anson.huang@....com>
> wrote:
> > > Subject: Re: [PATCH V3 3/3] pinctrl: imx: Support building i.MX
> > > pinctrl core driver as module
> > >
> > > On Tue, Sep 8, 2020 at 9:20 AM Anson Huang <Anson.Huang@....com>
> > > wrote:
> > >
> > > >  # SPDX-License-Identifier: GPL-2.0-only  config PINCTRL_IMX
> > > > -       bool
> > > > +       tristate "IMX pinctrl core driver"
> > > > +       depends on OF
> > > >         select GENERIC_PINCTRL_GROUPS
> > > >         select GENERIC_PINMUX_FUNCTIONS
> > > >         select GENERIC_PINCONF
> > >
> > > I don't see why you need to make this option user-visible when it is
> > > already selected by the drivers that need it. Wouldn't it be enough to
> change the 'bool'
> > > to 'tristate' without adding a prompt?
> >
> > Make sense, so it is same for PINCTRL_IMX_SCU, right?
> 
> Yes, correct.
> 
> I wasn't on Cc on the other two patches, so I missed that.

Sorry, I missed to add you to the list as I just use the list from get_maintainer script, will
add you in V4. Since most of the major comments are addressed, I will send V4 soon.

Thanks,
Anson