linux-kernel - Re: [PATCH] fs: align IOCB_* flags with RWF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <33762071-da92-9e63-639d-8afc0e65dcc7@kernel.dk>
Date:   Mon, 7 Sep 2020 20:12:07 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Jann Horn <jannh@...gle.com>
Subject: Re: [PATCH] fs: align IOCB_* flags with RWF_* flags

On 9/7/20 2:15 PM, Matthew Wilcox wrote:
> On Mon, Aug 31, 2020 at 12:08:10PM -0600, Jens Axboe wrote:
>> We have a set of flags that are shared between the two and inherired
>> in kiocb_set_rw_flags(), but we check and set these individually.
>> Reorder the IOCB flags so that the bottom part of the space is synced
>> with the RWF flag space, and then we can do them all in one mask and
>> set operation.
>>
>> The only exception is RWF_SYNC, which needs to mark IOCB_SYNC and
>> IOCB_DSYNC. Do that one separately.
>>
>> This shaves 15 bytes of text from kiocb_set_rw_flags() for me.
>>
>> Signed-off-by: Jens Axboe <axboe@...nel.dk>
> 
> Suggested-by: Matthew Wilcox (Oracle) <willy@...radead.org>

Added

-- 
Jens Axboe