linux-kernel - Re: [PATCH v6 27/35] i2c: tegra: Factor out register polling into separate function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b1db9d5-2b4c-97ae-f7f6-c750e76491d0@gmail.com>
Date:   Tue, 8 Sep 2020 16:33:55 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        Wolfram Sang <wsa@...-dreams.de>,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        linux-tegra@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 27/35] i2c: tegra: Factor out register polling into
 separate function

08.09.2020 11:51, Andy Shevchenko пишет:
> On Tue, Sep 8, 2020 at 5:12 AM Dmitry Osipenko <digetx@...il.com> wrote:
>>
>> Factor out register polling into a separate function in order to remove
>> boilerplate code and make code cleaner.
> 
> I'm wondering if you can make it before the patch that touches one of
> these conditionals.
> 

I guess you're meaning the "Improve coding style of
tegra_i2c_wait_for_config_load()" patch.

If yes, then it should be fine to swap the order. Although, I'm not sure
what's benefit.