linux-kernel - Re: [PATCH v3 06/15] MIPS: generic: Allow boards to set system type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAdtpL4TLbjtMZojKhQ3mkYHusdnp_05fLhm44bGuEv0icP+Nw@mail.gmail.com>
Date:   Tue, 8 Sep 2020 18:27:25 +0200
From:   Philippe Mathieu-Daudé <f4bug@...at.org>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        "Maciej W . Rozycki" <macro@...ux-mips.org>,
        Paul Burton <paulburton@...nel.org>,
        Zhou Yanjie <zhouyanjie@...yeetech.com>, od@...c.me,
        open list <linux-kernel@...r.kernel.org>,
        "open list:BROADCOM NVRAM DRIVER" <linux-mips@...r.kernel.org>
Subject: Re: [PATCH v3 06/15] MIPS: generic: Allow boards to set system type

On Sun, Sep 6, 2020 at 9:31 PM Paul Cercueil <paul@...pouillou.net> wrote:
>
> Check for the (already existing) "system_type" variable in the
> get_system_type() function. If non-NULL, return it as the system type.

Nitpick: It is not already "existing", simply declared in asm/bootinfo.h.

>
> Signed-off-by: Paul Cercueil <paul@...pouillou.net>
> ---
>
> Notes:
>     v2: Instead of adding a .get_system_type callback to the mips_machine
>         struct, the boards now simply override the "system_type" variable
>         when they want to set a custom one.
>
>     v3: No change
>
>  arch/mips/generic/proc.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/arch/mips/generic/proc.c b/arch/mips/generic/proc.c
> index 4c992809cc3f..cce2fde219a3 100644
> --- a/arch/mips/generic/proc.c
> +++ b/arch/mips/generic/proc.c
> @@ -8,11 +8,16 @@
>
>  #include <asm/bootinfo.h>
>
> +char *system_type;
> +
>  const char *get_system_type(void)
>  {
>         const char *str;
>         int err;
>
> +       if (system_type)
> +               return system_type;
> +
>         err = of_property_read_string(of_root, "model", &str);
>         if (!err)
>                 return str;
> --
> 2.28.0
>