linux-kernel - Re: [PATCH: V2 2/2] gpio: tc35894: Disable Direct KBD interrupts to enable gpio irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200908140415.GW4400@dell>
Date:   Tue, 8 Sep 2020 15:04:15 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     dillon.minfei@...il.com
Cc:     linus.walleij@...aro.org, bgolaszewski@...libre.com,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH: V2  2/2] gpio: tc35894: Disable Direct KBD interrupts to
 enable gpio irq

On Thu, 03 Sep 2020, dillon.minfei@...il.com wrote:

> From: dillon min <dillon.minfei@...il.com>
> 
> On tc35894, have to disable direct keypad interrupts to make
> it as general purpose interrupts functionality work.
> if not, after chip reset, IRQST(0x91) will always 0x20,
> IRQN always low level, can't be clear.
> 
> Configure DIRECTx to enable general purpose gpio mode,
> else read GPIOMISx register always zero in irq routine.
> 
> verified on tc35894, need more test on other tc3589x.
> 
> Signed-off-by: dillon min <dillon.minfei@...il.com>
> ---
>  
> V1 -> V2:
> Add DIRECTx register configuration to active general purpose gpio mode.
> 
>  drivers/gpio/gpio-tc3589x.c | 18 ++++++++++++++++--

>  include/linux/mfd/tc3589x.h |  6 ++++++

Acked-by: Lee Jones <lee.jones@...aro.org>

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog