linux-kernel - Re: [PATCH v6 24/35] i2c: tegra: Rename wait/poll functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29a288f6-3a78-8006-b457-a6ce766d1358@gmail.com>
Date:   Tue, 8 Sep 2020 16:26:09 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        Wolfram Sang <wsa@...-dreams.de>,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        linux-tegra@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 24/35] i2c: tegra: Rename wait/poll functions

08.09.2020 11:45, Andy Shevchenko пишет:
> On Tue, Sep 8, 2020 at 5:11 AM Dmitry Osipenko <digetx@...il.com> wrote:
>>
>> Drop '_timeout' postfix from the wait/poll completion function names in
>> order to make the names shorter, making code cleaner a tad.
> 
> ...
> 
>> +       time_left = tegra_i2c_wait_completion(i2c_dev, &i2c_dev->msg_complete,
>> +                                             50);
> 
> Why not one line?
> 

It goes over 80 chars, which is still a preferred max-length, although
it's not a mandatory limit anymore. For example I have a code editor
setup that is tuned for 80 chars, allowing to have multiple files viewed
and edited simultaneously.

But I think in the case of this particular hunk of the code, the
indentation improvement would indeed overweight the code-length. I'll
change it in v6, thanks!