linux-kernel - Re: [PATCH v2 1/6] dt-bindings: mfd: Add ENE KB930 Embedded Controller binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 8 Sep 2020 11:09:31 -0600
From:   Rob Herring <robh@...nel.org>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Pavel Machek <pavel@....cz>, Lubomir Rintel <lkundrak@...sk>,
        Mark Brown <broonie@...nel.org>, devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Lee Jones <lee.jones@...aro.org>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        linux-tegra <linux-tegra@...r.kernel.org>,
        Dan Murphy <dmurphy@...com>,
        Thierry Reding <thierry.reding@...il.com>,
        Sebastian Reichel <sre@...nel.org>,
        "open list:THERMAL" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH v2 1/6] dt-bindings: mfd: Add ENE KB930 Embedded
 Controller binding

On Fri, Sep 4, 2020 at 9:54 AM Dmitry Osipenko <digetx@...il.com> wrote:
>
> 04.09.2020 18:40, Rob Herring пишет:
> > On Fri, Sep 4, 2020 at 6:07 AM Dmitry Osipenko <digetx@...il.com> wrote:
> >>
> >> 03.09.2020 19:10, Rob Herring пишет:
> >>> On Sun, 30 Aug 2020 21:53:51 +0300, Dmitry Osipenko wrote:
> >>>> Add binding document for the ENE KB930 Embedded Controller.
> >>>>
> >>>> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> >>>> ---
> >>>>  .../devicetree/bindings/mfd/ene-kb930.yaml    | 66 +++++++++++++++++++
> >>>>  1 file changed, 66 insertions(+)
> >>>>  create mode 100644 Documentation/devicetree/bindings/mfd/ene-kb930.yaml
> >>>>
> >>>
> >>>
> >>> My bot found errors running 'make dt_binding_check' on your patch:
> >>>
> >>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/ene-kb930.example.dt.yaml: battery-cell: 'operating-range-celsius' does not match any of the regexes: '^ocv-capacity-table-[0-9]+$', 'pinctrl-[0-9]+'
> >>>       From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/power/supply/battery.yaml
> >>>
> >>>
> >>> See https://patchwork.ozlabs.org/patch/1354004
> >>>
> >>> If you already ran 'make dt_binding_check' and didn't see the above
> >>> error(s), then make sure dt-schema is up to date:
> >>>
> >>> pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
> >>>
> >>> Please check and re-submit.
> >>>
> >>
> >> Apparently bot uses outdated kernel.
> >
> > It's on v5.9-rc2. The scripts don't know your base/dependencies and
> > neither did I because you didn't mention anything here. I do review
> > the errors before spamming people.
>
> The patches are based on the linux-next, hence nothing special here. My
> expectation is that the bot should use the linux-next as well in order
> to prevent such warnings. Is there any reason to why bot not using
> linux-next?

What the bot uses is not the issue. The issue is not stating what your
dependencies are. linux-next is not a stable base. No patches to be
applied should be based on linux-next because there's no maintainer
that can take them if you consider anything in linux-next could be a
dependency. Of course, you're probably just dependent on one
maintainer's tree usually, but whose tree? Am I supposed to figure
that out?

linux-next is frequently broken with respect to binding checks, so it
really doesn't work for the bot. I need a known good base.

Rob