linux-kernel - Re: linux-next: Tree for Sep 8 (sched/topology.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e6295346-0202-498a-d503-14f81022dbec@infradead.org>
Date:   Tue, 8 Sep 2020 10:17:05 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Valentin Schneider <valentin.schneider@....com>
Cc:     Vincent Guittot <vincent.guittot@...aro.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>
Subject: Re: linux-next: Tree for Sep 8 (sched/topology.c)

On 9/8/20 9:28 AM, Valentin Schneider wrote:
> 
> On 08/09/20 17:07, Valentin Schneider wrote:
>> On 08/09/20 16:50, Randy Dunlap wrote:
>>> Sure, here it is again.  And
>>> CONFIG_SMP=y
>>> CONFIG_SCHED_DEBUG=y
>>>
>>> thanks.
>>
>> Okay so I can reproduce that with GCC-10.1, now to figure out WTH is going on...
> 
> Yet another fail from my end, the declaration is conditioned by:
> 
>   CONFIG_SCHED_DEBUG
>   CONFIG_SMP
>   CONFIG_SYSCTL
> 
> that last one being ofc stupid. Below lets me build; I'll go get
> something with caffeine in it and double-check the shuffles I've done
> before sending an actual patch.
> 
> Thanks for the report!

Works for me.  Thanks.

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

> 
> ---
> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
> index 0d7896d2a0b2..0ca486aa296b 100644
> --- a/kernel/sched/debug.c
> +++ b/kernel/sched/debug.c
> @@ -185,6 +185,12 @@ late_initcall(sched_init_debug);
> 
>  #ifdef CONFIG_SMP
> 
> +#define SD_FLAG(_name, mflags) [__##_name] = { .meta_flags = mflags, .name = #_name },
> +const struct sd_flag_debug sd_flag_debug[] = {
> +#include <linux/sched/sd_flags.h>
> +};
> +#undef SD_FLAG
> +
>  #ifdef CONFIG_SYSCTL
> 
>  static struct ctl_table sd_ctl_dir[] = {
> @@ -245,12 +251,6 @@ set_table_entry(struct ctl_table *entry,
>         entry->proc_handler = proc_handler;
>  }
> 
> -#define SD_FLAG(_name, mflags) [__##_name] = { .meta_flags = mflags, .name = #_name },
> -const struct sd_flag_debug sd_flag_debug[] = {
> -#include <linux/sched/sd_flags.h>
> -};
> -#undef SD_FLAG
> -
>  static int sd_ctl_doflags(struct ctl_table *table, int write,
>                           void *buffer, size_t *lenp, loff_t *ppos)
>  {
> ---
> 


-- 
~Randy
Reported-by: Randy Dunlap <rdunlap@...radead.org>