linux-kernel - Re: [PATCH v2 08/11] misc: hisi_hikey_usb: Driver to support onboard USB gpio hub on Hikey960

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 9 Sep 2020 20:15:56 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc:     linuxarm@...wei.com, mauro.chehab@...wei.com,
        Yu Chen <chenyu56@...wei.com>,
        John Stultz <john.stultz@...aro.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Derek Kiernan <derek.kiernan@...inx.com>,
        Dragan Cvetic <dragan.cvetic@...inx.com>,
        Arnd Bergmann <arnd@...db.de>,
        "David S. Miller" <davem@...emloft.net>,
        Rob Herring <robh@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 08/11] misc: hisi_hikey_usb: Driver to support onboard
 USB gpio hub on Hikey960

On Wed, Sep 09, 2020 at 11:55:47AM +0200, Mauro Carvalho Chehab wrote:
> Em Wed, 9 Sep 2020 10:44:42 +0200
> Mauro Carvalho Chehab <mchehab+huawei@...nel.org> escreveu:
> 
> > Em Wed, 9 Sep 2020 10:35:55 +0200
> > Greg Kroah-Hartman <gregkh@...uxfoundation.org> escreveu:
> > 
> > > On Mon, Sep 07, 2020 at 05:59:32PM +0200, Mauro Carvalho Chehab wrote:  
> > > > From: Yu Chen <chenyu56@...wei.com>
> > > > 
> > > > The HiKey960 has a fairly complex USB configuration due to it
> > > > needing to support a USB-C port for host/device mode and multiple
> > > > USB-A ports in host mode, all using a single USB controller.
> > > > 
> > > > See schematics here:
> > > >   https://github.com/96boards/documentation/raw/master/consumer/hikey/hikey960/hardware-docs/HiKey960_Schematics.pdf
> > > > 
> > > > This driver acts as a usb-role-switch intermediary, intercepting
> > > > the role switch notifications from the tcpm code, and passing
> > > > them on to the dwc3 core.
> > > > 
> > > > In doing so, it also controls the onboard hub and power gpios in
> > > > order to properly route the data lines between the USB-C port
> > > > and the onboard hub to the USB-A ports.
> > > > 
> > > > Signed-off-by: Yu Chen <chenyu56@...wei.com>
> > > > [jstultz: Major rework to make the driver a usb-role-switch
> > > >           intermediary]
> > > > Signed-off-by: John Stultz <john.stultz@...aro.org>
> > > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> > > > ---
> > > >  MAINTAINERS                   |   7 ++
> > > >  drivers/misc/Kconfig          |   9 ++
> > > >  drivers/misc/Makefile         |   1 +
> > > >  drivers/misc/hisi_hikey_usb.c | 205 ++++++++++++++++++++++++++++++++++
> > > >  4 files changed, 222 insertions(+)
> > > >  create mode 100644 drivers/misc/hisi_hikey_usb.c    
> > > 
> > > Can this, and the next patch, go into my char-misc tree independent of
> > > the other patches in this series?   
> > 
> > Yes, they can go via char-misc tree. The drivers are independent.
> > 
> 
> Forgot to ask: should I re-send the patches on a separate series?

Sure, that would make things much easier for me so that I "know" I have
the right patches to apply.

thanks,

greg k-h