linux-kernel - Re: [PATCH] fs: omfs: use kmemdup() rather than kmalloc+memcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5efaa7be-1890-0169-d133-8dd40b238d6d@gmail.com>
Date:   Wed, 9 Sep 2020 20:04:15 +0100
From:   Alex Dewar <alex.dewar90@...il.com>
To:     Bob Copeland <me@...copeland.com>,
        linux-karma-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: omfs: use kmemdup() rather than kmalloc+memcpy

On 24/08/2020 22:17, Alex Dewar wrote:
> Issue identified with Coccinelle.
Gentle ping?
>
> Signed-off-by: Alex Dewar <alex.dewar90@...il.com>
> ---
>   fs/omfs/inode.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c
> index b76ec6b88ded..8867cefa79cf 100644
> --- a/fs/omfs/inode.c
> +++ b/fs/omfs/inode.c
> @@ -363,12 +363,11 @@ static int omfs_get_imap(struct super_block *sb)
>   		bh = sb_bread(sb, block++);
>   		if (!bh)
>   			goto nomem_free;
> -		*ptr = kmalloc(sb->s_blocksize, GFP_KERNEL);
> +		*ptr = kmemdup(bh->b_data, sb->s_blocksize, GFP_KERNEL);
>   		if (!*ptr) {
>   			brelse(bh);
>   			goto nomem_free;
>   		}
> -		memcpy(*ptr, bh->b_data, sb->s_blocksize);
>   		if (count < sb->s_blocksize)
>   			memset((void *)*ptr + count, 0xff,
>   				sb->s_blocksize - count);